Exclusively build for pwdata and filter out modules #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacksongoode
force-pushed
the
jackson/filter-modules
branch
4 times, most recently
from
1dd5e54
to
eaf8005
Compare
jacksongoode
force-pushed
the
jackson/filter-modules
branch
from
eaf8005
to
fcefe35
Compare
jacksongoode
force-pushed
the
jackson/filter-modules
branch
from
1f1a299
to
bc8ec6c
Compare
adkinsjd
reviewed
Apr 30, 2024
pycg/processing/preprocessor.py
Outdated
| if src_name.split(".")[0] not in self.exclusives: | ||
| continue | ||
|
|
||
| # Skip ignored modules |
There was a problem hiding this comment.
Why do we need to skip ignored modules down here and remove them from times above?
There was a problem hiding this comment.
Below is what happens when PyCG looks at an import declaration, the other ... in self.ignored_mods: case above is when we visit a module. I did this as a safety precaution more so I think PyCG could end up traversing through a ignored modules in both cases - though I could be wrong about this and we can test.
pycg/processing/preprocessor.py
Outdated
| @@ -205,6 +215,14 @@ def add_external_def(name, target): | |||
| tgt_name = import_item.asname if import_item.asname else import_item.name | |||
| imported_name = self.import_manager.handle_import(src_name, level) | |||
|
|
|||
| # Limit to exclusive module | |||
| if src_name.split(".")[0] not in self.exclusives: | |||
There was a problem hiding this comment.
What happens here if self.exclusives is None?
There was a problem hiding this comment.
Good catch, I'll add their default to be an empty array.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way we can pass in
["pwdata"]as a exclusive package to filter by and then skip all the Pipeline classes asignored_mods.